Remove obsolete flag for WINARM64, fix TBB library lookup on Windows#241
Merged
kevinushey merged 2 commits intoRcppCore:masterfrom Oct 7, 2025
Merged
Remove obsolete flag for WINARM64, fix TBB library lookup on Windows#241kevinushey merged 2 commits intoRcppCore:masterfrom
kevinushey merged 2 commits intoRcppCore:masterfrom
Conversation
andrjohns
changed the title
Contributor
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that
RcppParallelis using a newer version of the TBB, theTBB_USE_GCC_BUILTINSflag is irrelevant on Windows arm64The
tbbLibraryPath()function was also looking for.dllfiles on windows, so wasn't returning the static lib